From: Jasper St. Pierre Date: Sat, 16 Jun 2012 02:35:26 +0000 (-0400) Subject: extensionDownloader: Fix errors during error paths during installation X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~6390 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=8915bb4892bc2b46feb1349cdfaff7c68c7143a1;p=gnome-shell.git extensionDownloader: Fix errors during error paths during installation https://bugzilla.gnome.org/show_bug.cgi?id=679099 --- diff --git a/js/ui/extensionDownloader.js b/js/ui/extensionDownloader.js index ad7c5f539..b1c0810a3 100644 --- a/js/ui/extensionDownloader.js +++ b/js/ui/extensionDownloader.js @@ -54,7 +54,7 @@ function uninstallExtensionFromUUID(uuid) { function gotExtensionZipFile(session, message, uuid) { if (message.status_code != Soup.KnownStatusCode.OK) { - logExtensionError(uuid, 'downloading extension: ' + message.status_code); + ExtensionSystem.logExtensionError(uuid, 'downloading extension: ' + message.status_code); return; } @@ -63,7 +63,8 @@ function gotExtensionZipFile(session, message, uuid) { if (!dir.query_exists(null)) dir.make_directory_with_parents(null); } catch (e) { - logExtensionError('Could not create extension directory'); + ExtensionSystem.logExtensionError(uuid, 'Could not create extension directory'); + return; } let [file, stream] = Gio.File.new_tmp('XXXXXX.shell-extension.zip'); @@ -77,7 +78,7 @@ function gotExtensionZipFile(session, message, uuid) { null); if (!success) { - logExtensionError(uuid, 'extract: could not extract'); + ExtensionSystem.logExtensionError(uuid, 'extract: could not extract'); return; }